Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1893] Removed logic to downgrade Manager roles and remove Edit/Delete any collection permissions for Flexible Collections #7365

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[AC-1893] Removed logic to downgrade Manager roles and remove Edit/Delete any collection permissions for Flexible Collections #7365

merged 1 commit into from
Jan 11, 2024

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Dec 27, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Removing this logic from clients as it is now implemented on the API side bitwarden/server#3617

Code changes

  • Removed all ConfigService references that were added to get the Flexible Collections feature flag value
  • Removed logic to override the Manager type value and Edit/Delete assigned collections permissions

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@r-tome
[AC-1893] Removed logic to downgrade Manager roles and remove Edit/De…
b2b8133 
…lete any collection permissions for Flexible Collections
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Dec 27, 2023
@r-tome r-tome marked this pull request as ready for review December 27, 2023 15:31
@r-tome r-tome requested review from a team as code owners December 27, 2023 15:31
@r-tome r-tome mentioned this pull request Dec 27, 2023
Closed
@r-tome r-tome requested a review from eliykat December 27, 2023 15:38
cturnbull-bitwarden
cturnbull-bitwarden approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Billing changes look good!

LRNcardozoWDF
LRNcardozoWDF approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@LRNcardozoWDF LRNcardozoWDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eliykat
Copy link
Member

eliykat commented Jan 11, 2024

Merging this as it needs to be removed anyway as part of the opt-in work.

@eliykat eliykat merged commit 48643e4 into main Jan 11, 2024
61 checks passed
@eliykat eliykat deleted the ac/ac-1893/map-manager-to-user-role-server-side branch January 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cturnbull-bitwarden cturnbull-bitwarden cturnbull-bitwarden approved these changes

@eliykat eliykat eliykat approved these changes

@addisonbeck addisonbeck addisonbeck approved these changes

@LRNcardozoWDF LRNcardozoWDF LRNcardozoWDF approved these changes

Assignees
No one assigned
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-tome @eliykat @LRNcardozoWDF @addisonbeck @cturnbull-bitwarden