-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1786] deprecate manager role #6931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few other places where this is displayed in the front-end and we have to do this mapping. However, I noticed that it's also used in the CLI: https://github.com/bitwarden/clients/blob/master/apps/cli/src/commands/list.command.ts#L220-L233
Given that we have less control over when the CLI is updated, I think we have to update these mappings on the server side. (As @r-tome initially suggested.)
Can you please revert changes to member-dialog.component.ts
as that will be done server-side. I'll make a ticket. Then the rest of the changes should be good to go, thank you!
Done in 8245c67. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve merge conflicts, I think caused by the automatic re-basing.
8245c67
to
9d746c7
Compare
No New Or Fixed Issues Found |
Type of change
Objective
This PR is stacked on top of #6906 because they overlap a good bit.
Deprecates the ability to designate a user as
OrganizationUserType.Manager
behindFeatureFlags.FlexibleCollections
Code changes
apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts: Maps Manager role to User role when form group loadsReverted, as this will be handled on the server instead.Screenshots
FeatureFlag.FlexibleCollections
is false:FeatureFlag.FlexibleCollections
is true:Before you submit