Address PR feedback #6572
Address PR feedback #6572
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Primitive Obsession enc-string.ts
- String Heavy Function Arguments enc-string.ts
- Complex Method fido2-credential.export.ts: Fido2CredentialExport.toDomain
Annotations
Check notice on line 50 in libs/common/src/models/export/fido2-credential.export.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ No longer an issue: Complex Method
Fido2CredentialExport.toDomain is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in libs/common/src/platform/models/domain/enc-string.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 73.33% to 68.75%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in libs/common/src/platform/models/domain/enc-string.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: String Heavy Function Arguments
The ratio of strings in function arguments decreases from 73.33% to 68.75%, threshold = 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.