[PM-4280] MP reprompt not respected on passkey creation and retrieval #6550
CodeScene PR Check
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method fido2-authenticator.service.ts: Fido2AuthenticatorService.makeCredential
- Complex Method fido2-authenticator.service.ts: Fido2AuthenticatorService.getAssertion
✅ Positive Code Health Impact (highest to lowest):
- Complex Method fido2.component.ts: Fido2Component.submit
- Bumpy Road Ahead fido2.component.ts: Fido2Component.submit
Annotations
Check notice on line 244 in apps/browser/src/vault/popup/components/fido2/fido2.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ No longer an issue: Complex Method
Fido2Component.submit is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 244 in apps/browser/src/vault/popup/components/fido2/fido2.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ No longer an issue: Bumpy Road Ahead
Fido2Component.submit is no longer above the threshold for logical blocks with deeply nested code
Check warning on line 146 in libs/common/src/vault/services/fido2/fido2-authenticator.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
❌ Getting worse: Complex Method
Fido2AuthenticatorService.makeCredential increases in cyclomatic complexity from 25 to 29, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 259 in libs/common/src/vault/services/fido2/fido2-authenticator.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
❌ Getting worse: Complex Method
Fido2AuthenticatorService.getAssertion increases in cyclomatic complexity from 20 to 24, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in libs/common/src/vault/services/fido2/fido2-authenticator.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 7.09 to 7.82, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.