-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1453] Update TrialInitiationComponent with new standalone component #6448
Conversation
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
This reverts commit 2009ae4.
…rial-initiation-component
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No notes for the auth portion. Looks like a simple enough change. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 💯
…itwarden#6448) * import new standalone components directly into TrialInitiationModule instead of importing and re-exporting through LooseComponentsModule
Type of change
Objective
Split from #6230 to reduce PR size.
Update
TrialInitiationComponent
to import only the standalone components it needs, rather than the whole ofLooseComponentsModule
.This was included in the changeset tested by QA originally on #6230 so I don't think it needs to be tested again here.
The commit list is messed up, just look at the diff.
Code changes
Screenshots
Before you submit