Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1453] Update TrialInitiationComponent with new standalone component #6448

Merged
merged 39 commits into from
Oct 9, 2023

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Sep 29, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Split from #6230 to reduce PR size.

Update TrialInitiationComponent to import only the standalone components it needs, rather than the whole of LooseComponentsModule.

This was included in the changeset tested by QA originally on #6230 so I don't think it needs to be tested again here.

The commit list is messed up, just look at the diff.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

eliykat and others added 30 commits September 7, 2023 16:04
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
…anizationplanscomponent-and-related-components-out-of-loosecomponentsmodule
@eliykat eliykat changed the title Revert "Undo changes to vault code to reduce codeowners" [AC-1453] Update TrialInitiationComponent with new standalone component Sep 29, 2023
Base automatically changed from ac/ac-1453/move-organizationplanscomponent-and-related-components-out-of-loosecomponentsmodule to master October 3, 2023 19:36
@eliykat eliykat marked this pull request as ready for review October 4, 2023 01:13
@eliykat eliykat requested review from a team as code owners October 4, 2023 01:13
@eliykat eliykat enabled auto-merge (squash) October 4, 2023 01:14
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details70c27196-be3e-4e40-88e0-357aee6a5b62

No New Or Fixed Issues Found

Copy link
Contributor

@ike-kottlowski ike-kottlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes for the auth portion. Looks like a simple enough change. 👍🏻

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 💯

@eliykat eliykat merged commit 21fef9d into master Oct 9, 2023
@eliykat eliykat deleted the ac/ac-1453/update-trial-initiation-component branch October 9, 2023 03:06
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
…itwarden#6448)

* import new standalone components directly into TrialInitiationModule instead of
  importing and re-exporting through LooseComponentsModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants