[PM-4053] Add lint to try to limit reappearance of Safari memory leaks #6382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Hinton
approved these changes
Sep 25, 2023
BlackDex
pushed a commit
to BlackDex/bitwarden-clients
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Created two lints to forbid the usage of the two listeners that have caused memory leaks in Safari in the past. The leaks only seem to occur when the listeners are used in the popup window (and indirectly, in any services or classes that the popup uses).
The new rules apply to the entirety of
browserandlibs, with the exception of some subfolders ofautofillwhich use the forbidden functions but don't trigger the leak. If someone can think of a better file selection for all the files loaded in the popup window, let me know.