[PM-3914] Refactor Browser Extension Popout Windows

[cagonzalezcs]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Refactor how the browser extension uses pop-out windows, and migrate the logic within BrowserPopoutWindowService and PopupUtilsService to a new utils class BrowserPopupUtils to consolidate behavior. We're also updating any potential popups that open in a tab to open within a new window to facilitate consistency in the implementation.

Code changes

• apps/browser/src/auth/popup/two-factor.component.ts: As we are updating all "Extension Tab" instances of the popup to a "Window Popout" implementation, the change in this file facilitates closing a potential TwoFactorAuth popout.
• apps/browser/src/auth/popup/utils/auth-popout-window.spec.ts: Jest tests for the AuthPopoutWindow utils methods used to open popouts for the authentication purposes.
• apps/browser/src/auth/popup/utils/auth-popout-window.ts: Helper methods that facilitate opening popout windows for authentication purposes.
• apps/browser/src/autofill/background/notification.background.ts: Updating references in this file to consolidate behavior surrounding unlock popout windows.
• apps/browser/src/autofill/browser/context-menu-clicked-handler.ts: Updating references in this file to consolidate behavior for how we open master password reprompt popout windows.
• apps/browser/src/autofill/content/message_handler.ts: Removing unused messages that no longer trigger actionable behavior.
• apps/browser/src/autofill/notification/bar.ts: Updating naming of unlock popout to reference new naming structure for the unlock popout.
• apps/browser/src/autofill/services/autofill.service.spec.ts: Adding jest tests to reflect changes within the autofill service.
• apps/browser/src/autofill/services/autofill.service.ts: Adding a method to facilitate debouncing the opening of master password popouts, and updating references to how we open those popouts.
• apps/browser/src/background/commands.background.ts: Updating references to the popoutUtilsService class to fit new architecture.
• apps/browser/src/background/main.background.ts: Removing BrowserPopoutWindowService entirely.
• apps/browser/src/background/runtime.background.ts: Removing messages that were once used to open popouts in favor of leveraging opening popouts at the logical trigger point.
• apps/browser/src/platform/browser/browser-api.spec.ts: Adding tests for the added browser api helper methods
• apps/browser/src/platform/browser/browser-api.ts: Expanding the getWindow method to function with or without a window ID value. If an id is not provided, the method attempts to grab the current window that the user has active.Adding a updateWindowProperties method to facilitate repositioning and focusing any single use popout windows that might exist. Removing openBitwardenExtensionTab and closeBitwardenExtensionTab as those represent deprecated methods for facilitating user interactions with the popup outside of the popup itself.
• apps/browser/src/platform/popup/abstractions/browser-popout-window.service.ts: Removal of unused abstraction.
• apps/browser/src/platform/popup/browser-popout-window.service.ts: Removal of unused class.
• apps/browser/src/platform/popup/browser-popup-utils.spec.ts: Jest tests for the new BrowserPopoutUtils class, centralizing behavior for the BrowserPopoutWindowService and the PopupUtilsService class.
• apps/browser/src/platform/popup/browser-popup-utils.ts: New class used to centralize behavior for the BrowserPopoutWindowService and the PopupUtilsService classes.
• apps/browser/src/popup/components/pop-out.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/popup/components/private-mode-warning.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/popup/services/init.service.ts: Updating references to the PopupUtilsService
• apps/browser/src/popup/services/popup-close-warning.service.ts: New class PopupCloseWarningService that handles setting up an onbeforeunload event listener and enabling/disabling warning behavior based on the class instantiation.
• apps/browser/src/popup/services/popup-utils.service.ts: Removal of this unused class, logic migrated to BrowserPopupUtils.
• apps/browser/src/popup/services/services.module.ts: Updating references to the PopupUtilsService
• apps/browser/src/popup/settings/settings.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/popup/tabs.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/tools/popup/send/send-add-edit.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/tools/popup/send/send-groupings.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/tools/popup/send/send-type.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/vault/popup/components/vault/add-edit.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/vault/popup/components/vault/current-tab.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/vault/popup/components/vault/vault-items.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/vault/popup/components/vault/view.component.ts: Updating references to the PopupUtilsService
• apps/browser/src/vault/popup/utils/vault-popout-window.spec.ts: Jest tests for the VaultPopoutWindow utils
• apps/browser/src/vault/popup/utils/vault-popout-window.ts: Represents usage of popout windows specific to use cases where the vault is leveraging opening a popout.
• apps/browser/test.setup.ts: Jest test setup

Demonstration

Screen.Recording.2023-09-14.at.3.09.43.PM.mp4

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – ee2cf294-36b0-4c87-8119-41be5dea65e9

No New Or Fixed Issues Found

[Hinton]

I think it's a good start. I would like to see more code owned though.

[Hinton]

We're a bit back to having two classes again. Albeit one is static and one isn't.

I think we need to write up some guidance on which to use. I think the only stateful portion of PopupUtilsService is knowing if the extension is running in private mode which doesn't feel like something it should know.

[JaredSnider-Bitwarden]

LGTM!