-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PS-1196] Add option to disable hardware acceleration #2896
Changes from all commits
3fac86a
afb44b1
1d5a4af
078ea70
d9d74aa
ed43f82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ export class SettingsComponent implements OnInit { | |
vaultTimeoutAction: string; | ||
pin: boolean = null; | ||
disableFavicons = false; | ||
enableHardwareAcceleration = false; | ||
enableBrowserIntegration = false; | ||
enableBrowserIntegrationFingerprint = false; | ||
enableMinToTray = false; | ||
|
@@ -56,6 +57,8 @@ export class SettingsComponent implements OnInit { | |
enableMinToTrayDescText: string; | ||
enableCloseToTrayText: string; | ||
enableCloseToTrayDescText: string; | ||
enableHardwareAccelerationText: string; | ||
enableHardwareAccelerationDescText: string; | ||
startToTrayText: string; | ||
startToTrayDescText: string; | ||
|
||
|
@@ -97,6 +100,12 @@ export class SettingsComponent implements OnInit { | |
this.startToTrayText = this.i18nService.t(startToTrayKey); | ||
this.startToTrayDescText = this.i18nService.t(startToTrayKey + "Desc"); | ||
|
||
const enableHardwareAccelerationKey = "enableHardwareAcceleration"; | ||
this.enableHardwareAccelerationText = this.i18nService.t(enableHardwareAccelerationKey); | ||
this.enableHardwareAccelerationDescText = this.i18nService.t( | ||
enableHardwareAccelerationKey + "Desc" | ||
); | ||
|
||
Comment on lines
+103
to
+108
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once 60-61 is removed, this also needs to be removed. |
||
this.vaultTimeouts = [ | ||
// { name: i18nService.t('immediately'), value: 0 }, | ||
{ name: i18nService.t("oneMinute"), value: 1 }, | ||
|
@@ -155,6 +164,7 @@ export class SettingsComponent implements OnInit { | |
this.enableCloseToTray = await this.stateService.getEnableCloseToTray(); | ||
this.enableTray = await this.stateService.getEnableTray(); | ||
this.startToTray = await this.stateService.getEnableStartToTray(); | ||
this.enableHardwareAcceleration = await this.stateService.getEnableHardwareAcceleration(); | ||
|
||
this.alwaysShowDock = await this.stateService.getAlwaysShowDock(); | ||
this.showAlwaysShowDock = this.platformUtilsService.getDevice() === DeviceType.MacOsDesktop; | ||
|
@@ -415,4 +425,8 @@ export class SettingsComponent implements OnInit { | |
this.enableBrowserIntegrationFingerprint | ||
); | ||
} | ||
|
||
async saveHardwareAcceleration() { | ||
await this.stateService.setEnableHardwareAcceleration(this.enableHardwareAcceleration); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -930,6 +930,12 @@ | |||||
"enableTrayDesc": { | ||||||
"message": "Always show an icon in the system tray." | ||||||
}, | ||||||
"enableHardwareAcceleration": { | ||||||
"message": "Enable hardware acceleration" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
"enableHardwareAccelerationDesc": { | ||||||
"message": "Enable the application to make use of a discrete GPU. Restart is required." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
"startToTray": { | ||||||
"message": "Start To Tray Icon" | ||||||
}, | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -889,6 +889,12 @@ | |
"enableTrayDesc": { | ||
"message": "Always show an icon in the system tray." | ||
}, | ||
"enableHardwareAcceleration": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please only change the |
||
"message": "Enable hardware acceleration" | ||
}, | ||
"enableHardwareAccelerationDesc": { | ||
"message": "Enable the application to make use of a discrete GPU. Restart is required." | ||
}, | ||
"startToTray": { | ||
"message": "Start to tray icon" | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -930,6 +930,12 @@ | |
"enableTrayDesc": { | ||
"message": "Always show an icon in the system tray." | ||
}, | ||
"enableHardwareAcceleration": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please only change the |
||
"message": "Enable hardware acceleration" | ||
}, | ||
"enableHardwareAccelerationDesc": { | ||
"message": "Enable the application to make use of a discrete GPU. Restart is required." | ||
}, | ||
"startToTray": { | ||
"message": "Start to tray icon" | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,7 @@ const v1Keys: { [key: string]: string } = { | |
enableMinimizeToTray: "enableMinimizeToTray", | ||
enableStartToTray: "enableStartToTrayKey", | ||
enableTray: "enableTray", | ||
enableHardwareAcceleration: "enableHardwareAcceleration", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't believe we'll need a state migration for this. It's a new option that wasn't available before the migration. |
||
encKey: "encKey", // Generated Symmetric Key | ||
encOrgKeys: "encOrgKeys", | ||
encPrivate: "encPrivateKey", | ||
|
@@ -225,6 +226,9 @@ export class StateMigrationService< | |
globals.enableBrowserIntegrationFingerprint = | ||
(await this.get<boolean>(v1Keys.enableBrowserIntegrationFingerprint)) ?? | ||
globals.enableBrowserIntegrationFingerprint; | ||
globals.enableHardwareAcceleration = | ||
(await this.get<boolean>(v1Keys.enableHardwareAcceleration)) ?? | ||
globals.enableHardwareAcceleration; | ||
|
||
const userId = | ||
(await this.get<string>(v1Keys.userId)) ?? (await this.get<string>(v1Keys.entityId)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be unnecessary since we don't need to conditionally change what text is shown.