Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14417] Create admin TaskService #12891

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[PM-14417] Create admin TaskService #12891

wants to merge 19 commits into from

Conversation

gbubemismith
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14417

📔 Objective

  • A new AdminTaskService is registered and available for use within components in the Web client.
  • The AdminTaskService should have a functional default implementation. (e.g. DefaultAdminTaskService)

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@gbubemismith gbubemismith requested review from a team as code owners January 15, 2025 16:18
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details43149018-fa98-437b-8bdd-1b55440fa33b

Great job, no security vulnerabilities found in this Pull Request

@gbubemismith gbubemismith changed the base branch from main to vault/pm-14416/initial-task-service January 15, 2025 16:37
@gbubemismith gbubemismith requested review from a team as code owners January 15, 2025 16:37
@gbubemismith gbubemismith requested review from a team as code owners January 15, 2025 16:37
@gbubemismith gbubemismith changed the base branch from vault/pm-14416/initial-task-service to main January 15, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants