Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14949] Update TDE Decryption Option Text #12850

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented Jan 14, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14949

📔 Objective

Update the text for the TDE decryption options.

Note, we have to split up the paragraph into several translation strings because the text for each link needs to be its own string so that it can be interpolated within the <a> </a> brackets (such as <a>single organization</a>).

📸 Screenshots

Screenshot 2025-01-13 at 4 06 34 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Logo
Checkmarx One – Scan Summary & Detailsde7cac7d-b69b-441c-8561-deca83e872c8

Fixed Issues (5)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-apps-dialog.component.html: 15
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 15
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3
MEDIUM Client_Privacy_Violation /libs/vault/src/components/download-attachment/download-attachment.component.ts: 29
MEDIUM Client_Privacy_Violation /libs/vault/src/components/download-attachment/download-attachment.component.ts: 29

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.44%. Comparing base (e815f89) to head (566775a).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12850   +/-   ##
=======================================
  Coverage   34.44%   34.44%           
=======================================
  Files        2974     2974           
  Lines       90667    90667           
  Branches    16989    16989           
=======================================
  Hits        31233    31233           
  Misses      56968    56968           
  Partials     2466     2466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rr-bw rr-bw marked this pull request as ready for review January 14, 2025 18:11
@rr-bw rr-bw requested a review from a team as a code owner January 14, 2025 18:11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an easy update. Thank you for fixing the spacing in the template. 👍

@rr-bw rr-bw merged commit f82b8ca into main Jan 16, 2025
38 checks passed
@rr-bw rr-bw deleted the auth/pm-14949/update-tde-decryption-option-text branch January 16, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants