Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16104] [PM-15929] Org at risk members click on the card #12732

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

ttalty
Copy link
Contributor

@ttalty ttalty commented Jan 7, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15929

📔 Objective

Dialog to display the at risk members.

📸 Screenshots

image
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ttalty ttalty changed the title Org at risk members click on the card [PM-16104] [PM-15929] Org at risk members click on the card Jan 7, 2025
@ttalty ttalty marked this pull request as ready for review January 7, 2025 20:24
@ttalty ttalty requested a review from a team as a code owner January 7, 2025 20:24
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 34.28%. Comparing base (8062475) to head (1709677).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...telligence/app-at-risk-members-dialog.component.ts 0.00% 11 Missing ⚠️
...telligence/org-at-risk-members-dialog.component.ts 0.00% 9 Missing ⚠️
.../access-intelligence/all-applications.component.ts 0.00% 8 Missing ⚠️
...-insights/services/risk-insights-report.service.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12732      +/-   ##
==========================================
- Coverage   34.29%   34.28%   -0.01%     
==========================================
  Files        2931     2933       +2     
  Lines       90030    90065      +35     
  Branches    16910    16912       +2     
==========================================
+ Hits        30873    30877       +4     
- Misses      56699    56730      +31     
  Partials     2458     2458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One – Scan Summary & Details9788f78f-a0bf-48b6-acca-b841a9ce0782

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 17
detailsMethod at line 17 of /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html sends user information...
Attack Vector

@ttalty ttalty requested a review from djsmith85 January 7, 2025 20:40
@ttalty ttalty merged commit 52b6bfe into main Jan 13, 2025
39 of 40 checks passed
@ttalty ttalty deleted the tools/pm-16104/org-at-risk-dialog branch January 13, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants