[PM-16530] [BRE-283] Changes to support hardening on the Mac desktop app #12632
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BRE-283
VULN-37
📔 Objective
This PR adds support for the Mac desktop app to use Runtime Hardening. In addition, it adds a few exceptions that allow for the app to work when hardened.
Background
The current MAS build uses sandboxing (which is a requirement for MAS) but does not implement Apple's runtime hardening. This was reported in VULN-37. To verify the hardening, you can look at the output of codesign:
The following line contains the info on hardening, specifically the
flags
element:CodeDirectory v=20500 size=780 flags=0x10000(runtime) hashes=13+7 location=embedded
flags=0x10000(runtime)
as it does above.flags=0x0(none)
.Hardening vs. Sandboxing
Sandboxing
Hardening
The net effect of this PR is to make sure the MAS app has both Sandboxing and the Hardened Runtime.
Hardening Exceptions
The hardened runtime offers several exceptions to the runtime. This allows apps to adopt the hardened runtime even if they need to do specific things that the runtime would prevent.
This PR adds one exception:
com.apple.security.cs.allow-jit
. This exception allows the app to run Just-In-Time compiled code. Since the app is built on electron, we need to be able to allow for typescript execution as part of the normal functioning.All of the other aspects of runtime hardening are in full force and do not need an exception to function.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes