Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16505] new device verification browser scroll remove #12619

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Dec 30, 2024

🎟️ Tracking

PM-16505

📔 Objective

Added a hideFooter value to the extension anon wrapper for the browser call. This will remove the excess footer element and the scroll bar that appears on page 1 of the new device verification notification in the browser.

📸 Screenshots

Screenshot 2024-12-30 at 6 42 17 AM
Screenshot 2024-12-30 at 6 42 24 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner December 30, 2024 14:00
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details20c31e80-b857-40f1-97a9-cbdb968570d7

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (4f060d8) to head (1710f82).
Report is 23 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wrapper/extension-anon-layout-wrapper.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12619      +/-   ##
==========================================
- Coverage   33.77%   33.77%   -0.01%     
==========================================
  Files        2912     2912              
  Lines       90747    90751       +4     
  Branches    17164    17166       +2     
==========================================
  Hits        30648    30648              
- Misses      57710    57714       +4     
  Partials     2389     2389              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jingo88 Jingo88 merged commit 6bc0ad2 into main Jan 2, 2025
32 checks passed
@Jingo88 Jingo88 deleted the PM-16505-new-device-verification-browser-scroll branch January 2, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants