Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16507] update new device verification notice state definition #12608

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Dec 28, 2024

🎟️ Tracking

PM-16507

📔 Objective

When a user dismissed the new device verification notice on web, that dismissal only lasted on the one tab. Opening a new tab and logging in would should the user the notification again.

Updated the state definition to the NEW_DEVICE_VERIFICATION_NOTICE so the dismissal value can persist throughout new tabs.

📸 Screen Recording

PM-16507-web-dismiss-persist.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner December 28, 2024 03:08
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details41c43e01-8e7c-48cb-9cb2-6cb79d1c3ed1

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.77%. Comparing base (4f060d8) to head (22afb7d).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12608   +/-   ##
=======================================
  Coverage   33.77%   33.77%           
=======================================
  Files        2912     2912           
  Lines       90747    90747           
  Branches    17164    17164           
=======================================
  Hits        30648    30648           
  Misses      57710    57710           
  Partials     2389     2389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jingo88 Jingo88 merged commit 894dd2c into main Dec 31, 2024
77 checks passed
@Jingo88 Jingo88 deleted the PM-16507-persist-web-dismiss branch December 31, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants