[PM-15814]Alert owners of reseller-managed orgs to renewal events #12607
+233
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12607 +/- ##
==========================================
- Coverage 33.79% 33.76% -0.04%
==========================================
Files 2911 2912 +1
Lines 90718 90781 +63
Branches 17155 17173 +18
==========================================
- Hits 30655 30649 -6
- Misses 57674 57743 +69
Partials 2389 2389 ☔ View full report in Codecov by Sentry. |
|
@cyprain-okeke are the date formats localized? MM/DD/YYYY is not used in most places. |
…gs-to-renewal-events
…rs-of-reseller-managed-orgs-to-renewal-events' into pm-15814-alert-owners-of-reseller-managed-orgs-to-renewal-events
cturnbull-bitwarden
previously approved these changes
Dec 30, 2024
Jingo88
requested changes
Dec 31, 2024
| @@ -592,6 +599,7 @@ export class VaultComponent implements OnInit, OnDestroy { | |||
| .subscribe(); | |||
|
|
|||
| this.unpaidSubscriptionDialog$.pipe(takeUntil(this.destroy$)).subscribe(); | |||
| //this.resellerWarning1$.pipe(takeUntil(this.destroy$)).subscribe(); | |||
There was a problem hiding this comment.
This looks like leftover commented out code, okay to remove?
Jingo88
previously approved these changes
Dec 31, 2024
gbubemismith
requested changes
Dec 31, 2024
| @@ -187,6 +191,8 @@ export class VaultComponent implements OnInit, OnDestroy { | |||
| private hasSubscription$ = new BehaviorSubject<boolean>(false); | |||
| protected currentSearchText$: Observable<string>; | |||
| protected freeTrial$: Observable<FreeTrial>; | |||
| protected resellerWarning$: Observable<ResellerWarning | null>; | |||
| protected resellerWarning: ResellerWarning; | |||
There was a problem hiding this comment.
I don't think this variable is used anywhere
| @@ -592,6 +599,7 @@ export class VaultComponent implements OnInit, OnDestroy { | |||
| .subscribe(); | |||
|
|
|||
| this.unpaidSubscriptionDialog$.pipe(takeUntil(this.destroy$)).subscribe(); | |||
| //this.resellerWarning1$.pipe(takeUntil(this.destroy$)).subscribe(); | |||
There was a problem hiding this comment.
This should be removed if it's not needed anymore
| @@ -612,6 +619,16 @@ export class VaultComponent implements OnInit, OnDestroy { | |||
| }), | |||
| ); | |||
|
|
|||
| this.resellerWarning$ = combineLatest([organization$]).pipe( | |||
There was a problem hiding this comment.
I think we only need combineLatest when we have multiple independent streams. This can be simplified a bit
Suggested change
| this.resellerWarning$ = combineLatest([organization$]).pipe( | |
| this.resellerWarning$ = organization$.pipe( | |
| filter(org => org.isOwner), | |
| switchMap(org => this.billingApiService | |
| .getOrganizationBillingMetadata(org.id) | |
| .pipe(map(metadata => ({org, metadata}))) | |
| ), | |
| map() |
gbubemismith
previously approved these changes
Dec 31, 2024
Jingo88
previously approved these changes
Dec 31, 2024
cyprain-okeke
dismissed stale reviews from Jingo88 and gbubemismith
via
05e0d3b
cturnbull-bitwarden
approved these changes
Dec 31, 2024
gbubemismith
approved these changes
Dec 31, 2024
cyprain-okeke
deleted the
pm-15814-alert-owners-of-reseller-managed-orgs-to-renewal-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15814
📔 Objective
Organizations that are managed by a reseller have a higher probability of churning. This happens because of a breakdown in communication around renewal dates.
the managed org does not have visibility into when their renewal date is, because their billing is managed by the reseller. Without knowing their renewal date, the managed org cannot issue a purchase order to their reseller.
the reseller does not respond to invoices from Bitwarden because they do not include a purchase order number matching one from a customer of theirs (the managed org).
the first indication the managed org has that something has gone wrong is when the organization is suspended. This happens 30 days after the automatic invoice we send to the reseller is marked as unpaid, which is usually 45 days after it was issued (resellers get net-45 by default).
To help prevent this issue, we will show in-product messaging to owners of reseller-managed organizations, alerting them that their renewal date is upcoming, and to reach out to their reseller to insure uninterrupted service.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes