Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15333] Portable Desktop Fix #12586

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15333

Fixes #12141

📔 Objective

We need to support someone using the portable Bitwarden app using and signing in on one account then transporting the executable and data files to another computer and unlocking there. Right now we can't do that because we store the access token and refresh token in Credential Manager which is not portable to the new computer.

The one problem with this fix is that people who are using the portable app right now on a single computer have their access token in Credential Manager and after this change the app will be told secure store isn't supported and won't even look there thinking they don't have an access token and they will need to fully login again. @JaredSnider-Bitwarden and I will need to discuss this and maybe we want TokenService to still look there when it's not supported, but I don't love that.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur changed the title Portable Desktop Fix [PM-15333] Portable Desktop Fix Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (395258d) to head (b476ec5).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/app/services/services.module.ts 0.00% 1 Missing ⚠️
...atform/services/electron-platform-utils.service.ts 0.00% 1 Missing ⚠️
libs/common/src/auth/services/token.service.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12586      +/-   ##
==========================================
- Coverage   33.79%   33.78%   -0.01%     
==========================================
  Files        2912     2912              
  Lines       90701    90696       -5     
  Branches    17153    17152       -1     
==========================================
- Hits        30648    30640       -8     
- Misses      57667    57670       +3     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfd0a9f39-ae96-4ab8-812e-8c19dbe261a1

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portable App is No Longer Portable
1 participant