Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16470] Remove v1 autofill owned refresh code #12579

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16470

📔 Objective

  • Remove v1 autofill owned settings - 4c13eb1
  • Remove Fido2 v1 components - 38ce116
  • Remove conditional to enable AutofillOnPageLoadOrgPolicy - afd0b05

📸 Screenshots

Before After
image image
image image
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner December 25, 2024 13:01
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsdad4b6d7-1b23-46c0-a4cb-f0416ea52f5c

Fixed Issues

Severity Issue Source File / Package
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html: 1
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts: 103
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/notifications-v1.component.ts: 32
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts: 103
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.95%. Comparing base (ef70f7d) to head (afd0b05).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/background/runtime.background.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12579      +/-   ##
==========================================
+ Coverage   33.78%   33.95%   +0.17%     
==========================================
  Files        2912     2906       -6     
  Lines       90699    90252     -447     
  Branches    17152    17066      -86     
==========================================
+ Hits        30641    30648       +7     
+ Misses      57672    57218     -454     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants