Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16432] Remove v1 account security settings #12578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16432

📔 Objective

  • Remove v1 Account security settings
  • Remove conditional routing based on extensionRefresh feature flag
  • Clean up app.module

📸 Screenshots

Before After
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Delete v1 component
Remove conditional routing based on extension refresh feature flag
@djsmith85 djsmith85 requested a review from a team as a code owner December 25, 2024 12:29
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse0275cce-6562-4e2b-98c6-057cfea5e300

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.85%. Comparing base (ef70f7d) to head (3e866a8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12578      +/-   ##
==========================================
+ Coverage   33.78%   33.85%   +0.06%     
==========================================
  Files        2912     2911       -1     
  Lines       90699    90517     -182     
  Branches    17152    17109      -43     
==========================================
  Hits        30641    30641              
+ Misses      57672    57490     -182     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since KM owns most features controlled by this component I'll also add a review; LGTM, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants