[PM-15994] Move encryption to km ownership #12576
Open
+1,097
−991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues
|
quexten
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12576 +/- ##
==========================================
+ Coverage 33.78% 33.80% +0.01%
==========================================
Files 2912 2919 +7
Lines 90693 90608 -85
Branches 17151 17152 +1
==========================================
- Hits 30641 30630 -11
+ Misses 57666 57591 -75
- Partials 2386 2387 +1 ☔ View full report in Codecov by Sentry. |
quexten
requested review from
coroiu,
JimmyVo16,
shane-melton,
Patrick-Pimentel-Bitwarden and
justindbaur
and removed request for
coroiu
JimmyVo16
approved these changes
Dec 26, 2024
audreyality
requested changes
Dec 26, 2024
| @@ -1,6 +1,6 @@ | |||
| // FIXME: Update this file to be type safe and remove this and next line | |||
| // @ts-strict-ignore | |||
| import { EncString } from "../../platform/models/domain/enc-string"; | |||
| import { EncString } from "../../../../key-management/src/cryptography/domain/enc-string"; | |||
There was a problem hiding this comment.
@bitwarden/key-management. There's several like it. Please review the PR for all instances.
cturnbull-bitwarden
approved these changes
Dec 30, 2024
| import { OrgKey } from "@bitwarden/common/types/key"; | ||
|
|
||
| import { EncString } from "../../../../../key-management/src/cryptography/domain/enc-string"; |
There was a problem hiding this comment.
Can we use @bitwarden/key-management instead of relative pathing?
| import { | ||
| EncString, | ||
| EncryptedString, | ||
| } from "../../../../key-management/src/cryptography/domain/enc-string"; |
There was a problem hiding this comment.
Can we use @bitwarden/key-management instead of relative pathing?
jprusik
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15994
📔 Objective
Moves a lot of the remaining crypto domain from platform to km, since km will own the corresponding sdk code in the long term too. (Further, this also cleans up some internal km ownership and file structure in the process).
Specifically transferred:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes