Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16305] Add explicit aria-label to "Excluded domains" input #12536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrickhlauke
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Closes #12535

๐Ÿ“” Objective

Adds accessible name to input fields in Settings > Notifications > Excluded domains

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@patrickhlauke patrickhlauke requested a review from a team as a code owner December 22, 2024 00:10
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-16305
Link: https://bitwarden.atlassian.net/browse/PM-16305

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Add explicit aria-label to "Excluded domains" input [PM-16305] Add explicit aria-label to "Excluded domains" input Dec 22, 2024
@patrickhlauke
Copy link
Contributor Author

I'll admit I've not got my build pipeline / environment fully set up at this point (returning to this repo for the first time in ages), so not had a chance to build and test this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Settings > Notifications > Excluded domains - domain inputs lack accessible name
2 participants