Build desktop-native in alpine container #12499
Conversation
quexten
force-pushed
the
km/build-linux-desktop-native-natively
branch
from
e7ef6e9 to
0f3adf4
Compare
|
Fixed Issues
|
| TARGET: musl | ||
| run: | | ||
| source $HOME/.cargo/env | ||
| node build.js release |
There was a problem hiding this comment.
If this is using the build.js script in desktop_native, it doesn't have a release argument. It will ignore it and build on debug mode unless you pass the cross-platform arg. Should be fairly easy to add support for it though.
There was a problem hiding this comment.
I had added support, but it got lost when moving the changes from my testing branch on my personal repo to this; will re-add :)
| @@ -138,6 +138,41 @@ jobs: | |||
| NODE_VERSION=${NODE_NVMRC/v/''} | |||
| echo "node_version=$NODE_VERSION" >> $GITHUB_OUTPUT | |||
|
|
|||
| linux-desktop-native: | |||
There was a problem hiding this comment.
I noticed this new job doesn't have a cache step, do we know how long it takes to build? Not sure if it was needed before, but I'd rather not accidentally make the builds any slower hah
There was a problem hiding this comment.
~4 minutes https://github.com/quexten/clients/actions/runs/12430521534/job/34706128211
So adding cache is worth it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12499 +/- ##
=======================================
Coverage 33.78% 33.78%
=======================================
Files 2912 2912
Lines 90699 90699
Branches 17152 17152
=======================================
Hits 30641 30641
Misses 57672 57672
Partials 2386 2386 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes