Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16234] Move DesktopFido2UserInterfaceService and DesktopFido2UserInterfaceSession #12482

Conversation

coltonhurst
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16234

📔 Objective

Move DesktopFido2UserInterfaceService and DesktopFido2UserInterfaceSession (part of the same file) to Autofill team ownership. These will need to be implemented / used for the MacOS Desktop passkey UI.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Dec 19, 2024
@coltonhurst coltonhurst requested review from a team as code owners December 19, 2024 16:28
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsc9a830b6-bf64-428c-9526-499352b3f9fb

No New Or Fixed Issues Found

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coltonhurst coltonhurst merged commit 997d40f into main Dec 19, 2024
28 of 29 checks passed
@coltonhurst coltonhurst deleted the autofill/pm-16234/move-macos-af-interfaces-to-autofill-ownership branch December 19, 2024 19:55
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.56%. Comparing base (0f9e18b) to head (8074f31).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
apps/desktop/src/app/services/services.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12482   +/-   ##
=======================================
  Coverage   33.56%   33.56%           
=======================================
  Files        2926     2926           
  Lines       91527    91527           
  Branches    17395    17395           
=======================================
  Hits        30721    30721           
  Misses      58392    58392           
  Partials     2414     2414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants