Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move import to sdk and enable it in browser/web #12479

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 19, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16227

📔 Objective

Makes use of the sdk in order to handle import on desktop web and browser. Drops importer code from desktop_native since it's not needed there anymore.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsbe9e6034-71d0-4740-a6f0-77adbc25a1ef

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-password-history-v2/vault-password-history-v2.component.html: 7 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-password-history-v2/vault-password-history-v2.component.html: 7 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/password-history.component.html: 6 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/password-history.component.html: 6 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-password-history-v2/vault-password-history-v2.component.html: 7 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-password-history-v2/vault-password-history-v2.component.html: 7 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/password-history.component.html: 6 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/password-history.component.html: 6 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.ts: 21 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.ts: 21 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/item-history/item-history-v2.component.ts: 34 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/item-history/item-history-v2.component.ts: 34 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/item-history/item-history-v2.component.ts: 34 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/credential-generator-history.component.html: 3
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: 11
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: 11
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 878

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.44%. Comparing base (d1fe72a) to head (646f245).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...vault/popup/components/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
.../desktop/src/vault/app/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12479      +/-   ##
==========================================
- Coverage   33.52%   33.44%   -0.08%     
==========================================
  Files        2913     2924      +11     
  Lines       91086    91390     +304     
  Branches    17338    17379      +41     
==========================================
+ Hits        30533    30567      +34     
- Misses      58146    58415     +269     
- Partials     2407     2408       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant