Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PUX SSH PR to use SDK #12478

Draft
wants to merge 2 commits into
base: tools/PM-10938/1pux-ssh-key-import
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 19, 2024

🎟️ Tracking

📔 Objective

Updates the PR to use the sdk for parsing the 1Password provided PKCS8 keys.

NOTE: This is untested, I do not have a 1Password pux file available at the moment, but the importing code in the SDK has unit tests for 1Password provided keys.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from djsmith85 December 19, 2024 13:41
@quexten quexten requested a review from a team as a code owner December 19, 2024 13:41
@quexten quexten changed the title Update PR to use SDK Update PUX SSH PR to use SDK Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Details59cc9ceb-c96c-4aa1-9b04-153974ac2b26

New Issues

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2024-12692 Npm-electron-33.2.1 Vulnerable Package
CRITICAL CVE-2024-12694 Npm-electron-33.2.1 Vulnerable Package
CRITICAL CVE-2024-12695 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-11112 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-11113 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-11114 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-12053 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-12381 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-12382 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-12693 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2024-21538 Npm-cross-spawn-7.0.3 Vulnerable Package
HIGH CVE-2024-52798 Npm-path-to-regexp-0.1.10 Vulnerable Package
HIGH Cxdca8e59f-8bfe Npm-inflight-1.0.6 Vulnerable Package
MEDIUM CVE-2024-11110 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-11111 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-11116 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-11117 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2024-55565 Npm-nanoid-3.3.7 Vulnerable Package
MEDIUM CVE-2024-6531 Npm-bootstrap-4.6.0 Vulnerable Package
MEDIUM Cx14b19a02-387a Npm-body-parser-1.20.3 Vulnerable Package
MEDIUM Cx877cf216-175c Npm-event-pubsub-4.3.0 Vulnerable Package
MEDIUM Cx8ef77360-5422 Npm-node-ipc-9.2.1 Vulnerable Package
MEDIUM Cx949f3fb2-a0e5 Npm-js-message-1.0.7 Vulnerable Package
MEDIUM Cxafe14174-3b5a Npm-easy-stack-1.0.1 Vulnerable Package
MEDIUM Cxf62a1409-bb90 Npm-js-queue-2.0.2 Vulnerable Package
LOW Cx8bc4df28-fcf5 Npm-debug-2.6.9 Vulnerable Package
LOW Cx8bc4df28-fcf5 Npm-debug-4.3.7 Vulnerable Package
LOW Cx8bc4df28-fcf5 Npm-debug-3.2.7 Vulnerable Package
LOW Cxda14f253-4e52 Npm-bluebird-3.7.2 Vulnerable Package

@quexten quexten marked this pull request as draft December 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant