Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16217] Remove wasm timeout #12476

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[PM-16217] Remove wasm timeout #12476

merged 3 commits into from
Dec 20, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 19, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16217

📔 Objective

Remove the WASM timeout logic and supported$.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner December 19, 2024 10:34
@Hinton Hinton requested a review from coroiu December 19, 2024 10:34
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Details50247ec5-2e40-4f07-9b81-c67abee34ec1

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 878

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.60%. Comparing base (456046e) to head (9e8b2e8).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...latform/services/sdk/browser-sdk-client-factory.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/app.component.ts 0.00% 1 Missing ⚠️
apps/web/src/app/app.component.ts 0.00% 1 Missing ⚠️
...n/src/platform/services/sdk/default-sdk.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12476      +/-   ##
==========================================
+ Coverage   33.49%   33.60%   +0.10%     
==========================================
  Files        2917     2926       +9     
  Lines       91163    91439     +276     
  Branches    17348    17375      +27     
==========================================
+ Hits        30535    30725     +190     
- Misses      58228    58300      +72     
- Partials     2400     2414      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coroiu
coroiu previously approved these changes Dec 19, 2024
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see code removal 👍

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even more removals

@Hinton Hinton merged commit 8caadac into main Dec 20, 2024
71 checks passed
@Hinton Hinton deleted the remove-wasm-timeout branch December 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants