Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9674] Remove Deprecated LockComponents #12453

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented Dec 17, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9674

📔 Objective

This PR deletes the legacy lock components from the Angular clients and also removes feature flag control from the routing. The lock component will now be based entirely on the new, recently refreshed LockComponent in libs/auth/angular.

Note that the before this PR, the legacy lock component(s) were called LockComponent, whereas the refreshed lock component was called LockV2Component. This PR deletes the legacy lock components and then updates the refreshed lock component to now be LockComponent.

📸 Screenshots

Videos below are just to verify that the refreshed LockComponent still works and was not somehow broken by these changes.

Web

web.mov

Browser Extension

browser.mov

Desktop

desktop.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Details096d6967-0316-44e6-8ee7-af3626a22386

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/lock.component.ts: 20
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/lock.component.ts: 20
MEDIUM Client_Privacy_Violation /apps/desktop/src/auth/lock.component.html: 32

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (2e6031e) to head (b1c66c4).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/auth/src/angular/lock/lock.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12453      +/-   ##
==========================================
+ Coverage   33.60%   33.68%   +0.07%     
==========================================
  Files        2925     2921       -4     
  Lines       91460    91046     -414     
  Branches    17385    17252     -133     
==========================================
- Hits        30734    30665      -69     
+ Misses      58308    57994     -314     
+ Partials     2418     2387      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rr-bw rr-bw marked this pull request as ready for review December 18, 2024 19:24
@rr-bw rr-bw requested a review from a team as a code owner December 18, 2024 19:24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, confirmed with Ryan he reran through the logouts 👍

@rr-bw rr-bw merged commit d209da4 into main Dec 20, 2024
70 of 72 checks passed
@rr-bw rr-bw deleted the auth/pm-9674/remove-deprecated-lock-components branch December 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants