-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-9674] Remove Deprecated LockComponents #12453
Conversation
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12453 +/- ##
==========================================
+ Coverage 33.60% 33.68% +0.07%
==========================================
Files 2925 2921 -4
Lines 91460 91046 -414
Branches 17385 17252 -133
==========================================
- Hits 30734 30665 -69
+ Misses 58308 57994 -314
+ Partials 2418 2387 -31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good, confirmed with Ryan he reran through the logouts 👍
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9674
📔 Objective
This PR deletes the legacy lock components from the Angular clients and also removes feature flag control from the routing. The lock component will now be based entirely on the new, recently refreshed
LockComponent
inlibs/auth/angular
.Note that the before this PR, the legacy lock component(s) were called
LockComponent
, whereas the refreshed lock component was calledLockV2Component
. This PR deletes the legacy lock components and then updates the refreshed lock component to now beLockComponent
.📸 Screenshots
Videos below are just to verify that the refreshed
LockComponent
still works and was not somehow broken by these changes.Web
web.mov
Browser Extension
browser.mov
Desktop
desktop.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes