[PM-14347][PM-14348] New Device Verification Logic

[nick-livefront]

🎟️ Tracking

PM-14347
PM-14348

📔 Objective

Stacked on top of @Jingo88's PR: #12360

Adds logic for new device verification pages, guards and state

• Adds check for scenarios when the new device verification is hidden
• Adds logic for temporary flag which will be shown every 7 days until the user enables 2 factor auth
• Adds logic for permanent flag which is blocking until the user enables two factor auth or selects they have reliable access.
• Adds missing question mark to "access to email" copy

📸 Screenshots

Temporary	Permanent
new-device-temporary.mov	new-device-permanent.mov

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 5fe7dd2d-64bf-4cc5-b396-383b0b4e6011

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 40	Attack Vector
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 50	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 40
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 50
	Client_JQuery_Deprecated_Symbols	/apps/cli/src/service-container/service-container.ts: 878

[codecov]

Codecov Report

Attention: Patch coverage is 93.24324% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.55%. Comparing base (1d04a0a) to head (a57b6b7).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ult/guards/new-device-verification-notice.guard.ts	84.84%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12451      +/-   ##
==========================================
+ Coverage   33.44%   33.55%   +0.11%     
==========================================
  Files        2924     2925       +1     
  Lines       91420    91485      +65     
  Branches    17381    17391      +10     
==========================================
+ Hits        30574    30698     +124     
+ Misses      58438    58375      -63     
- Partials     2408     2412       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shane-melton]

Looks really good! Just noticed one issue with regards to the active userId and caching the profile.

Also, thanks for all the tests!! 🧪 🎉

[shane-melton]

Looks good! Nice work!

The base branch was changed.

[nick-livefront]

Rebased because #12360 was merged into main. I also tacked on a commit to short circuit the logic when both of the feature flags are not true: a57b6b7, that way it avoids any unneeded logic being executed.