-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-15593 Standard Login UI is shown when item has no Auth key added #12432
Open
dan-livefront
wants to merge
6
commits into
main
Choose a base branch
from
PM-15593-Standard-Login-UI-is-shown-when-item-has-no-Auth-key-added
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PM-15593 Standard Login UI is shown when item has no Auth key added #12432
dan-livefront
wants to merge
6
commits into
main
from
PM-15593-Standard-Login-UI-is-shown-when-item-has-no-Auth-key-added
+92
−539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Issues
Fixed Issues
|
…m-has-no-Auth-key-added
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12432 +/- ##
=======================================
Coverage 33.56% 33.56%
=======================================
Files 2926 2926
Lines 91527 91534 +7
Branches 17395 17398 +3
=======================================
+ Hits 30721 30726 +5
Misses 58392 58392
- Partials 2414 2416 +2 ☔ View full report in Codecov by Sentry. |
…m-has-no-Auth-key-added
coltonhurst
reviewed
Dec 17, 2024
...autofill/overlay/inline-menu/pages/list/__snapshots__/autofill-inline-menu-list.spec.ts.snap
Show resolved
Hide resolved
jprusik
reviewed
Dec 18, 2024
apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts
Outdated
Show resolved
Hide resolved
jprusik
approved these changes
Dec 19, 2024
…m-has-no-Auth-key-added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/93?selectedIssue=PM-15593
📔 Objective
Only display totp ciphers when the field is a totp field and there is a totp code
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes