Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8214] New Device Verification Notice UI #12360

Merged
merged 37 commits into from
Dec 19, 2024

inline email message into markup

2ac259d
Select commit
Loading
Failed to load commit list.
Merged

[PM-8214] New Device Verification Notice UI #12360

inline email message into markup
2ac259d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

33.50% (-0.02%) compared to 1d874b4

View this Pull Request on Codecov

33.50% (-0.02%) compared to 1d874b4

Details

Codecov Report

Attention: Patch coverage is 27.11864% with 86 lines in your changes missing coverage. Please review.

Project coverage is 33.50%. Comparing base (1d874b4) to head (2ac259d).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ult/guards/new-device-verification-notice.guard.ts 0.00% 29 Missing ⚠️
...w-device-verification-notice-page-two.component.ts 30.00% 24 Missing and 4 partials ⚠️
...w-device-verification-notice-page-one.component.ts 36.36% 17 Missing and 4 partials ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 2 Missing ⚠️
apps/desktop/src/app/app-routing.module.ts 0.00% 2 Missing ⚠️
apps/web/src/app/oss-routing.module.ts 0.00% 2 Missing ⚠️
libs/angular/src/services/jslib-services.module.ts 0.00% 1 Missing ⚠️
libs/angular/src/vault/guards/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12360      +/-   ##
==========================================
- Coverage   33.52%   33.50%   -0.02%     
==========================================
  Files        2913     2921       +8     
  Lines       91086    91229     +143     
  Branches    17338    17358      +20     
==========================================
+ Hits        30540    30570      +30     
- Misses      58139    58251     +112     
- Partials     2407     2408       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov