Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12273] use organization properties for access permissions #12358

Merged
merged 4 commits into from
Dec 15, 2024

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12273

📔 Objective

This PR adds access permissions to the integrations page and the tabs within the integration page.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner December 11, 2024 20:33
@BTreston BTreston requested review from r-tome and eliykat December 11, 2024 20:33
@eliykat eliykat requested review from JimmyVo16 and removed request for r-tome December 11, 2024 23:47
@eliykat
Copy link
Member

eliykat commented Dec 11, 2024

This is a rebase of #12260 so I've added @JimmyVo16 as the other reviewer of that PR.

@BTreston BTreston requested a review from eliykat December 12, 2024 15:15
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsd8baff3d-eb62-4570-99aa-9f4dff0ff3ff

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 878 Attack Vector
LOW Unprotected_Cookie /apps/web/src/app/auth/sso.component.ts: 175 Attack Vector

Fixed Issues

Severity Issue Source File / Package
LOW Unprotected_Cookie /apps/web/src/app/auth/core/services/login/web-sso-component.service.ts: 19
LOW Unprotected_Cookie /apps/web/src/app/auth/sso-v1.component.ts: 175

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 33.43%. Comparing base (d4fcb58) to head (d967d2a).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ganizations/integrations/integrations.component.ts 0.00% 9 Missing ⚠️
...on/src/admin-console/models/domain/organization.ts 0.00% 2 Missing ⚠️
...nizations/layouts/organization-layout.component.ts 0.00% 1 Missing ⚠️
...nsole/organizations/organization-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12358      +/-   ##
==========================================
- Coverage   33.49%   33.43%   -0.07%     
==========================================
  Files        2898     2908      +10     
  Lines       90370    90982     +612     
  Branches    17170    17322     +152     
==========================================
+ Hits        30268    30416     +148     
- Misses      57709    58166     +457     
- Partials     2393     2400       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

(org.productTierType === ProductTierType.Enterprise ||
org.productTierType === ProductTierType.Teams) &&
featureFlagEnabled,
).pipe(filter((enabled) => enabled && org.isAdmin && org.canAccessIntegrations)),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment: It looks like we already checked for isAdmin in canAccessIntegrations. Do we need it here as well?

Copy link

@JimmyVo16 JimmyVo16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me, but could you post a screenshot of the testing artifact?

@BTreston
Copy link
Contributor Author

The code changes look good to me, but could you post a screenshot of the testing artifact?
Screenshot 2024-12-12 at 4 04 14 PM
Screenshot 2024-12-12 at 4 03 51 PM

@BTreston BTreston requested a review from JimmyVo16 December 12, 2024 21:13
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 minor change

@BTreston BTreston requested a review from eliykat December 13, 2024 14:39
@BTreston BTreston enabled auto-merge (squash) December 13, 2024 15:17
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@BTreston BTreston merged commit 31be6a7 into main Dec 15, 2024
71 checks passed
@BTreston BTreston deleted the ac/pm-12273-integration-page-access-permissions branch December 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants