-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12273] use organization properties for access permissions #12358
[PM-12273] use organization properties for access permissions #12358
Conversation
This is a rebase of #12260 so I've added @JimmyVo16 as the other reviewer of that PR. |
apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts
Outdated
Show resolved
Hide resolved
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12358 +/- ##
==========================================
- Coverage 33.49% 33.43% -0.07%
==========================================
Files 2898 2908 +10
Lines 90370 90982 +612
Branches 17170 17322 +152
==========================================
+ Hits 30268 30416 +148
- Misses 57709 58166 +457
- Partials 2393 2400 +7 ☔ View full report in Codecov by Sentry. |
(org.productTierType === ProductTierType.Enterprise || | ||
org.productTierType === ProductTierType.Teams) && | ||
featureFlagEnabled, | ||
).pipe(filter((enabled) => enabled && org.isAdmin && org.canAccessIntegrations)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment: It looks like we already checked for isAdmin
in canAccessIntegrations
. Do we need it here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me, but could you post a screenshot of the testing artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 1 minor change
apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12273
📔 Objective
This PR adds access permissions to the integrations page and the tabs within the integration page.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes