Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14461] Update organization state after subscription update #12222

Merged

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Dec 3, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14461

📔 Objective

This PR updates the updatePasswordManagerSeats invocation in the organization-api.service to take in a ProfileOrganizationResponse from the server. It then uses that response to update the organization state after the organization's seats have been updated.

Server PR: bitwarden/server#5103

📸 Screenshots

Screen.Recording.2024-12-03.at.12.41.58.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One – Scan Summary & Detailsf80b6571-9fca-4f3a-9d60-c78474eeb16b

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (6539f06) to head (0c156ee).
Report is 19 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ing/organizations/adjust-subscription.component.ts 0.00% 7 Missing ⚠️
.../organizations/sm-adjust-subscription.component.ts 0.00% 7 Missing ⚠️
.../services/organization/organization-api.service.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12222      +/-   ##
==========================================
- Coverage   33.79%   33.77%   -0.02%     
==========================================
  Files        2911     2911              
  Lines       90716    90732      +16     
  Branches    17154    17157       +3     
==========================================
- Hits        30655    30648       -7     
- Misses      57672    57695      +23     
  Partials     2389     2389              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BTreston
BTreston previously approved these changes Dec 3, 2024
cyprain-okeke
cyprain-okeke previously approved these changes Dec 5, 2024
jonashendrickx
jonashendrickx previously approved these changes Dec 5, 2024
@github-actions github-actions bot temporarily deployed to Web Vault - US QA Cloud December 19, 2024 23:54 Inactive
@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud December 23, 2024 14:30 Inactive
@github-actions github-actions bot temporarily deployed to Web Vault - US QA Cloud December 30, 2024 19:24 Inactive
@amorask-bitwarden amorask-bitwarden merged commit 15cc4ff into main Jan 2, 2025
72 of 74 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-14461/refresh-org-state-after-seat-update branch January 2, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants