Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-506] Upgrade to Angular 18 #12218

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[CL-506] Upgrade to Angular 18 #12218

wants to merge 13 commits into from

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Dec 3, 2024

🎟️ Tracking

CL-506

📔 Objective

This PR upgrades our version of Angular to 18, including all peer modules.

One of the updated modules is ng-select, which had a major version update. This required an update to the Content Security Policy for the web app, which normally blocks inline style blocks but has exceptions for specific styles. These exceptions take the form of sha256 hashes, which are basically encoded versions of the exact harcoded style block. ng-select must have had changes to their stylesheet, so we needed to update the hash.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One – Scan Summary & Details68cc7c37-0c56-446f-b16a-81b049b6c4ad

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.74%. Comparing base (c074543) to head (6173262).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/app.module.ts 0.00% 1 Missing ⚠️
bitwarden_license/bit-web/src/app/app.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12218      +/-   ##
==========================================
+ Coverage   33.73%   33.74%   +0.01%     
==========================================
  Files        2918     2918              
  Lines       90994    90994              
  Branches    17200    17200              
==========================================
+ Hits        30693    30703      +10     
+ Misses      57901    57891      -10     
  Partials     2400     2400              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 changed the title Ds/cl 506/angular 18 [CL-506] Upgrade to Angular 18 Dec 3, 2024
@vleague2 vleague2 marked this pull request as ready for review December 3, 2024 20:20
@vleague2 vleague2 requested a review from a team as a code owner December 3, 2024 20:20
dani-garcia
dani-garcia previously approved these changes Dec 4, 2024
@willmartian willmartian added the needs-qa Marks a PR as requiring QA approval label Dec 4, 2024
willmartian
willmartian previously approved these changes Dec 4, 2024
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@vleague2 vleague2 dismissed stale reviews from willmartian and dani-garcia via 5c08158 December 4, 2024 20:55
@vleague2 vleague2 requested a review from a team as a code owner December 4, 2024 20:55
@vleague2 vleague2 requested a review from JimmyVo16 December 4, 2024 20:55
@vleague2
Copy link
Contributor Author

vleague2 commented Dec 4, 2024

@JimmyVo16 Sorry for the ping -- the file that your team owns is just a temporary change to make QA easier, and will be reverted before this is merged, so no need to review!

JimmyVo16
JimmyVo16 previously approved these changes Dec 6, 2024
@@ -256,7 +256,7 @@ const devServer =
'sha256-JVRXyYPueLWdwGwY9m/7u4QlZ1xeQdqUj2t8OVIzZE4='
'sha256-or0p3LaHetJ4FRq+flVORVFFNsOjQGWrDvX8Jf7ACWg='
'sha256-jvLh2uL2/Pq/gpvNJMaEL4C+TNhBeGadLIUyPcVRZvY='
'sha256-Oca9ZYU1dwNscIhdNV7tFBsr4oqagBhZx9/p4w8GOcg='
'sha256-VZTcMoTEw3nbAHejvqlyyRm1Mdx+DVNgyKANjpWw0qg='
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a note to be added to our release cards to ensure the prod rules are updated pre-release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for this comment -- I am now working with sre to get the rules updated for the QA environments and for prod!

@github-actions github-actions bot temporarily deployed to Web Vault - US QA Cloud December 10, 2024 17:06 Inactive
@github-actions github-actions bot temporarily deployed to Web Vault - US QA Cloud December 23, 2024 19:12 Inactive
@vleague2 vleague2 removed the needs-qa Marks a PR as requiring QA approval label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants