-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL-506] Upgrade to Angular 18 #12218
base: main
Are you sure you want to change the base?
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12218 +/- ##
==========================================
+ Coverage 33.73% 33.74% +0.01%
==========================================
Files 2918 2918
Lines 90994 90994
Branches 17200 17200
==========================================
+ Hits 30693 30703 +10
+ Misses 57901 57891 -10
Partials 2400 2400 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty!
5c08158
@JimmyVo16 Sorry for the ping -- the file that your team owns is just a temporary change to make QA easier, and will be reverted before this is merged, so no need to review! |
@@ -256,7 +256,7 @@ const devServer = | |||
'sha256-JVRXyYPueLWdwGwY9m/7u4QlZ1xeQdqUj2t8OVIzZE4=' | |||
'sha256-or0p3LaHetJ4FRq+flVORVFFNsOjQGWrDvX8Jf7ACWg=' | |||
'sha256-jvLh2uL2/Pq/gpvNJMaEL4C+TNhBeGadLIUyPcVRZvY=' | |||
'sha256-Oca9ZYU1dwNscIhdNV7tFBsr4oqagBhZx9/p4w8GOcg=' | |||
'sha256-VZTcMoTEw3nbAHejvqlyyRm1Mdx+DVNgyKANjpWw0qg=' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a note to be added to our release cards to ensure the prod rules are updated pre-release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty for this comment -- I am now working with sre to get the rules updated for the QA environments and for prod!
🎟️ Tracking
CL-506
📔 Objective
This PR upgrades our version of Angular to 18, including all peer modules.
One of the updated modules is
ng-select
, which had a major version update. This required an update to the Content Security Policy for the web app, which normally blocks inline style blocks but has exceptions for specific styles. These exceptions take the form of sha256 hashes, which are basically encoded versions of the exact harcoded style block.ng-select
must have had changes to their stylesheet, so we needed to update the hash.ng-select
issue about their use of inline styles and its CSP consequences, and MDN article about using hashes for CSP⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes