-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14999] Remove Sequentialize #12113
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12113 +/- ##
==========================================
- Coverage 33.78% 33.76% -0.02%
==========================================
Files 2912 2911 -1
Lines 90706 90664 -42
Branches 17155 17152 -3
==========================================
- Hits 30646 30614 -32
+ Misses 57672 57663 -9
+ Partials 2388 2387 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
3b5417d
No New Or Fixed Issues Found |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14999
📔 Objective
Sequentialize was used to give back a cached unfulfilled promise back to later callers. But we've come a long way since this was added and you know what's even better? Not calling this method to many times in a short period of time.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes