-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth/PM-8113 - 2FA Components UI Refresh #12087
base: main
Are you sure you want to change the base?
Conversation
…of UnauthenticatedExtensionUIRefresh flag
…ed import is used a dialog.
…s-ui-refresh + merge conflict fixes
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12087 +/- ##
=======================================
Coverage 33.51% 33.52%
=======================================
Files 2886 2885 -1
Lines 90185 90162 -23
Branches 17150 17147 -3
=======================================
- Hits 30230 30226 -4
+ Misses 57565 57547 -18
+ Partials 2390 2389 -1 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
…ead of libs/angular/src/auth
…en top level page component and child components
…tor-auth and move all logic into single component - WIP
…s-ui-refresh + merge confliction resolution
…nt imports on other clients.
…ulLoginNavigate (3) after successful login we always loginEmailService.clearValues()
…ions + mark methods as abstract properly + add null return to getProviders
…d guard. Updated all routes.
…ndling into primary init with checks based on client for if it should be processed.
…ogic into ExtensionTwoFactorAuthComponentService
…r web's determineLegacyKeyMigrationAction method.
…provedForEmail2fa to replace extension specific init logic.
…ed check for optional window close. + Add todo
…ce architecture (2) Move openPopoutIfApprovedForEmail2fa to new TwoFactorAuthEmailComponentService
…tion and each clients implementation of the duo2faResultListener
…for launchDuoFrameless
…s-ui-refresh + merge conflict fixes
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8113
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes