Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing i18n #12083

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix missing i18n #12083

merged 1 commit into from
Nov 21, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 21, 2024

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten marked this pull request as ready for review November 21, 2024 12:03
@quexten quexten requested a review from willmartian November 21, 2024 12:03
@quexten quexten mentioned this pull request Nov 21, 2024
@quexten quexten enabled auto-merge (squash) November 21, 2024 12:04
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.45%. Comparing base (5e6c5c8) to head (3aa401e).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12083      +/-   ##
==========================================
- Coverage   33.45%   33.45%   -0.01%     
==========================================
  Files        2863     2864       +1     
  Lines       89638    89666      +28     
  Branches    17059    17067       +8     
==========================================
+ Hits        29990    29995       +5     
- Misses      57287    57310      +23     
  Partials     2361     2361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@quexten quexten merged commit eea460e into main Nov 21, 2024
26 checks passed
@quexten quexten deleted the km/missing-i18n-fix branch November 21, 2024 12:16
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1627083d-f4f1-43a8-a1ad-86d2ce0fedcc

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants