-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-5550 Implement on-page autofil for single line TOTP #12058
Merged
dan-livefront
merged 24 commits into
main
from
PM-5550-implement-on-page-autofill-menu-for-totp
Dec 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
85a6736
PM-5550 initial commit -Initial render
dan-livefront 49fc569
Merge branch 'main' into PM-5550-implement-on-page-autofill-menu-for-โฆ
dan-livefront dcd4ae2
Merge branch 'main' into PM-5550-implement-on-page-autofill-menu-for-โฆ
dan-livefront 6f68692
add refresh overlay
dan-livefront 164b770
localize and clean up
dan-livefront 897fe61
- Clean up code
dan-livefront 172c806
version()
dan-livefront 48a8b7e
Merge branch 'main' into PM-5550-implement-on-page-autofill-menu-for-โฆ
dan-livefront 44d076a
Add and translate aria labels
dan-livefront a20eb14
Merge branch 'main' into PM-5550-implement-on-page-autofill-menu-for-โฆ
dan-livefront 8c82c86
Merge branch 'PM-5550-implement-on-page-autofill-menu-for-totp' of giโฆ
dan-livefront f258bef
add aria labels
dan-livefront 00b96fd
implement feature flag
dan-livefront 7b4aaf0
address totp tests
dan-livefront c53b767
Merge branch 'main' into PM-5550-implement-on-page-autofill-menu-for-โฆ
dan-livefront e5e2715
clean up totpfield function
dan-livefront 911ab15
fix styling and tests, update snapshots
dan-livefront 2e6f878
Update apps/browser/src/_locales/en/messages.json
dan-livefront 0c23dee
Update apps/browser/src/_locales/en/messages.json
dan-livefront c9831a4
remove group tag
dan-livefront 97f9692
update snapshots
dan-livefront 9c2c03e
adress feedback
dan-livefront e7a7277
merge conflict
dan-livefront 8aa2616
Merge branch 'main' into PM-5550-implement-on-page-autofill-menu-for-โฆ
dan-livefront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (for follow up work in next PRs, don't worry about it in this one), let's move that comment to be more local to the line in question:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do! good call out.