Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14964] revert passphrase minimum #12019

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Conversation

audreyality
Copy link
Member

@audreyality audreyality commented Nov 15, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14964

📔 Objective

Revert 0254550 and explain recommended boundaries using hint text.

📸 Screenshots

No policy; value exceeds recommended value:

image image

No policy; value less than or equal to recommended value:

image image

With policy; value exceeds recommended value:

image image

With policy' value less than or equal to recommended value:

image image

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner November 15, 2024 23:41
@ginat

This comment was marked as resolved.

@audreyality audreyality changed the title revert passphrase minimim [PM-14964] revert passphrase minimim Nov 15, 2024
@audreyality audreyality changed the title [PM-14964] revert passphrase minimim [PM-14964] revert passphrase minimum Nov 15, 2024
@audreyality

This comment was marked as resolved.

@ginat

This comment was marked as resolved.

This comment was marked as off-topic.

@bwbug

This comment was marked as off-topic.

@audreyality

This comment was marked as resolved.

@audreyality audreyality marked this pull request as draft November 18, 2024 14:39
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.48%. Comparing base (0308e6e) to head (9828f29).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/tools/generator/core/src/data/generators.ts 0.00% 2 Missing ⚠️
...nizations/policies/password-generator.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12019   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files        2846     2849    +3     
  Lines       89196    89244   +48     
  Branches    17002    17006    +4     
=======================================
+ Hits        29867    29884   +17     
- Misses      56976    57006   +30     
- Partials     2353     2354    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@audreyality audreyality marked this pull request as ready for review November 18, 2024 17:30
@audreyality audreyality requested a review from a team as a code owner November 18, 2024 17:30
@audreyality audreyality requested a review from eliykat November 18, 2024 17:30
vincentsalucci
vincentsalucci previously approved these changes Nov 18, 2024
Copy link
Member

@vincentsalucci vincentsalucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to AC owned file password-generator.component look good 👍

djsmith85

This comment was marked as resolved.

@audreyality audreyality enabled auto-merge (squash) November 18, 2024 19:37
@audreyality audreyality merged commit 3521c54 into main Nov 18, 2024
66 checks passed
@audreyality audreyality deleted the tools/revert-passphrase-minimum branch November 18, 2024 19:43
@bwbug bwbug mentioned this pull request Nov 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select less than 6 words for Passphrase in Edge Extension
5 participants