-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14964] revert passphrase minimum #12019
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12019 +/- ##
=======================================
Coverage 33.48% 33.48%
=======================================
Files 2846 2849 +3
Lines 89196 89244 +48
Branches 17002 17006 +4
=======================================
+ Hits 29867 29884 +17
- Misses 56976 57006 +30
- Partials 2353 2354 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to AC owned file password-generator.component
look good 👍
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14964
📔 Objective
Revert 0254550 and explain recommended boundaries using hint text.
📸 Screenshots
No policy; value exceeds recommended value:
No policy; value less than or equal to recommended value:
With policy; value exceeds recommended value:
With policy' value less than or equal to recommended value:
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes