-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14892] Tax estimation for individuals #11992
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11992 +/- ##
==========================================
- Coverage 33.42% 33.40% -0.03%
==========================================
Files 2871 2876 +5
Lines 89791 89856 +65
Branches 17098 17106 +8
==========================================
+ Hits 30012 30014 +2
- Misses 57417 57479 +62
- Partials 2362 2363 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
No New Or Fixed Issues Found |
…r-Clients' into PM-14892-Sales-Tax-Estimation-For-Clients
{ name: "Zimbabwe", value: "ZW", disabled: false }, | ||
]; | ||
|
||
private taxSupportedCountryCodes: string[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list seems to match the supported tax id types for the countries in Stripe. I've moved this bit to the back-end.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14892
📔 Objective
onTaxInformationChanged
event will emit when country, postal code or tax id have changed, with a 1 second delay to make sure you're done typing. This allows components that integrate this component to listen for changes, and preview the invoice accordingly according to the entered data in the tax information form.📸 Screenshots
See comment section on https://bitwarden.atlassian.net/browse/PM-13999 for recording.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes