[BEEEP][PM-14388] Better dev experience on desktop-browser IPC

[dani-garcia]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14388

📔 Objective

This PR tries to improve developer experience on desktop-browser integration by removing some unnecessary steps.

• Allow enabling biometric integration on desktop MacOS, even if the app is not an appstore build, when launching it in dev mode. This should make it much faster to test changes without waiting for a full build+signing. In my testing it seems to work perfectly fine.
• When building the IPC code in debug mode, use a TMP directory instead of the App Groups folder. As the app won't be codesigned, using App Groups leads to a lot of popups asking for access to that folder.
• Try to detect any bitwarden extension installed in the chrome based browsers by reading their preferences and add their extension to the allowlist. This is to make it easier to test dev builds of the browser extension, which generates a random extension id per user. Previously devs had to manually patch the manifest file, which is specially annoying now that we regenerate it each time, but this should be done automatically for them now.
• Reorganized and unified the Linux browser detection logic a bit to move it closer to what we do for Mac and Windows. This should make it easier to add other chrome-based browsers in the future. It also revealed that we weren't deleting the manifest from chromium before, that's fixed as well.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (4a2c14d) to head (17009f7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/desktop/src/main/native-messaging.main.ts	0.00%	40 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11822      +/-   ##
==========================================
- Coverage   33.55%   33.53%   -0.02%     
==========================================
  Files        2814     2814              
  Lines       87435    87464      +29     
  Branches    16674    16677       +3     
==========================================
- Hits        29337    29330       -7     
- Misses      55793    55829      +36     
  Partials     2305     2305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[justindbaur]

Looks great, one question, is there any world where a dev would want to opt out of this improvement?

For example in browser we don't show the welcome tab on install but we added a way to opt out of that so you can test the more production like experience.

I think this differs in that it's actually making the dev experience MORE like production but just wanted to offer it up as a question.

[justindbaur]

Genius

[dani-garcia]

@quexten should get the props for this idea, he's the one who came up with it 😄

[dani-garcia]

Looks great, one question, is there any world where a dev would want to opt out of this improvement?

For example in browser we don't show the welcome tab on install but we added a way to opt out of that so you can test the more production like experience.

I think this differs in that it's actually making the dev experience MORE like production but just wanted to offer it up as a question.

I think most of the changes as you mention only bring us closer to what production should be, and the differences that these changes enable aren't really behavioral, they just unblock certain features that previously weren't working in dev, so I can't imagine there's many reasons to disable them.

For testing a more production build on MacOS, you'll need to test against a masdev build to make sure the sanbdox isn't causing any issues anyway, and in production builds these changes don't have any effect.