Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Platform: Update Rust crate zbus to v5 - autoclosed #11734

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 28, 2024

This PR contains the following updates:

Package Type Update Change
zbus dependencies major =4.4.0 -> =5.1.1

Release Notes

dbus2/zbus (zbus)

v5.1.1: πŸ”– zbus 5.1.1

Compare Source

  • βž– Tie async-process dependency to async-io feature, instead of the target OS. This fixes
    tokio users (a big majority of our users) needlessly depending on it along with a bunch of its
    dependencies.
  • πŸ”Š Don't log error on broadcasting on generic message channel. Otherwise, we just end up with a
    lot of noise in the logs.

v5.1.0: πŸ”– zbus 5.1.0

Compare Source

  • ⬇️ Reduce rust-version to 1.80. #​1107
  • 🦺 Verify validity of names and object paths pased to macros at compile time.
  • πŸ› Generate interface properties signal methods only when needed.
  • ♻️ Use winnow for parsing GUID and D-Bus address strings. #​1070
  • ✨ Add support for unixexec transport.
  • πŸ”Œ Add Command stdio socket type. This socket communicates with a spawned child process via
    its standard input and output streams.
  • βž• Add direct dep on winnow.

v5.0.1: πŸ”– zbus 5.0.1

Compare Source

  • πŸ“Œ Don't pin zvariant_utils dep. We don't always release zvariant_utils together with other
    crates, so unlike the macros crates, the versions don't need to be tied together. This will also
    allow us to bring zvariant_utils improvements to users without having to release all dependent
    packages as well.

v5.0.0: πŸ”– zbus 5.0.0

Compare Source

  • πŸ‘½οΈ Adapt to zvariant 5.0 API. This brings in massive performance improvements to message
    encoding and decoding.
  • πŸ’₯ Breakinging changes:
    • Message body signature now mandatory.
    • proxy macro respects visibility. This includes all types generated by proxy. Unfortunately
      this means that the existing code will have to set the visiblity explicitly to pub if they
      were relying on the generated proxy to be public.
    • Drop support for DBUS_COOKIE_SHA1 auth mechanism. #​727
      • It drags the sha1 crate as a dependency, which can be problematic for some users. #​543
      • It makes the handshake more complex, not allowing to pipeline all the commands.
      • It's not widely used. If EXTERNAL is not an option, you might as well just use ANONYMOUS.
    • πŸ›‚ Only support one authentication method at a time. Now that we're down to only two
      authentication mechanisms with one of them being no-authentication, this really makes sense
      since we can just autodetect what authentication method to use for a specific socket type on a
      specific platform. This also simplifies the handshake logic and will allow us to pipeline the
      whole client-side handshake in the future, when we can drop the xdg-dbus-proxy workarounds. #​781
    • Drop unnecessary lifetimes on genarated signal streams.
    • Streamline Message & message::Builder constructors. They should be named the same and take the
      same type of arguments.
    • proxy::Defaults now has typed values.
    • Rename proxy::ProxyDefault to proxy::Defaults.
    • πŸ”₯ Drop API deprecated in 4.0.
    • Minor changes in fdo API.
  • ✨ New features:
    • interface now generates a trait, Signals, that provides the same signal
      methods as user specifies but w/o the SignalEmitter argument (#​871). The macro also generates
      2 implementations of this trait for:
      • InterfaceRef, for emitting signals from outside the context of an interface
        method.
      • SignalEmitter, for emitting signals from inside an interface methods.
    • Add SignalContext::emit. Add a new method to SignalContext that allows emitting a signal for
      a given interface and singal name.
    • Add Connection::graceful_shutdown.
    • Add conn::AuthMechanism::as_str(). This gives you a static string representation of the
      mechanism. We'll use this in a following commit to avoid an allocation.
    • Add Socket::auth_mechanism. The socket impl will now inform us which authentication mechanism
      should be used with it. The implementation can choose this based on the socket type and the
      target platform.
    • Allow specifying visibility of interface-generated proxy. This implies that by default, it will
      be private.
    • ObjectServer now implements Clone.
  • 🚚 Renames and moves:
    • Rename SignalContext to SignalEmitter. Since now this emits signals, this is a more
      appropriate name. We keep a deprecated SignalContext type alias as well as the
      signal_context attribute of interface for not completely breaking the existing code.
    • Move AuthMechanism from crate root to conn. We leave the AuthMechanism in the root as
      deprecated.
  • πŸš‘οΈ Gracefully handle serial number wrap. When SERIAL_NUM wraps past u32::MAX back to zero,
    the conversion to NonZeroU32 panics. #​946
  • 🩹 Fix some lifetimes in Proxy API. We were unnecessarily constraining the lifetimes in some of
    the Proxy API.
  • ⚑️ Optimizations
    • Only enable Guid::generate() if p2p feature is enabled.
    • Use relaxed load order for serial number fetch & add.
    • msg::Header no longer allocates.
    • Avoid deserialization of msg::Header needlessly.
  • 🚩 Add serde_bytes Cargo feature. This is just a proxy feature for zvariant's serde_bytes
    feature. #​1052
  • 🚩 Feature-gate blocking API. Add a cargo feature called blocking-api to zbus &
    zbus_macros. When enabled, the zbus::blocking module is available. When disabled, proxy
    macro ignores the value of gen_blocking attribute and doesn't generate blocking proxy. This
    feature is enabled by default.
  • βž• Add camino feature as proxy for zvariant feature of the same name.
  • βž– Dependendies removed:
    • Remove dependency on sha1 crate.
    • Drop direct dep on futures-sink.
    • rand now an optional dependency. It is only enabled if p2p feature is enabled. This means
      that rand dependency is dropped for typical users.
  • ⬆️ Updated dependencies:
    • zvariant to 5.0.
    • windows-sys to 0.59.
    • tokio-vsock 5. #​643
  • ⬆️ Bump MSRV to 1.81.
  • πŸ“ Documentation
    • Tidy documentation across entire crate.
    • Improve blocking module docs.
    • Correct wrong documentation links.
    • Remove a now incorrect warning from Message::header method.
  • ✏️ Fix doc list item missing indentation.
  • 🚨 Drop invalid cfg from documentation example.

Configuration

πŸ“… Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Oct 28, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

β™» Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: apps/desktop/desktop_native/Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path apps/desktop/desktop_native/core/Cargo.toml --package [email protected] --precise 5.1.1
    Updating crates.io index
error: failed to select a version for the requirement `zbus = "^4"`
candidate versions found which didn't match: 5.1.1
location searched: crates.io index
required by package `zbus_polkit v4.0.0`
    ... which satisfies dependency `zbus_polkit = "=4.0.0"` (locked to 4.0.0) of package `desktop_core v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/core)`
    ... which satisfies path dependency `desktop_core` (locked to 0.0.0) of package `desktop_napi v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/napi)`

@renovate renovate bot requested a review from a team as a code owner October 28, 2024 00:20
@renovate renovate bot requested a review from justindbaur October 28, 2024 00:20
@bitwarden-bot
Copy link

Internal tracking:

@bitwarden-bot bitwarden-bot changed the title [deps] Platform: Update Rust crate zbus to v5 [PM-14074] [deps] Platform: Update Rust crate zbus to v5 Oct 28, 2024
@renovate renovate bot changed the title [PM-14074] [deps] Platform: Update Rust crate zbus to v5 [deps] Platform: Update Rust crate zbus to v5 Oct 28, 2024
@renovate renovate bot force-pushed the renovate/zbus-5.x branch from f903c91 to 39f2733 Compare November 3, 2024 01:42
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 33.41%. Comparing base (5592d64) to head (68b1d12).
Report is 176 commits behind head on main.

βœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11734   +/-   ##
=======================================
  Coverage   33.41%   33.41%           
=======================================
  Files        2841     2841           
  Lines       89008    89008           
  Branches    16979    16979           
=======================================
  Hits        29744    29744           
  Misses      56927    56927           
  Partials     2337     2337           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/zbus-5.x branch 3 times, most recently from 0628ccf to 66683e5 Compare November 11, 2024 21:54
@renovate renovate bot force-pushed the renovate/zbus-5.x branch from 66683e5 to 68b1d12 Compare November 12, 2024 01:17
@renovate renovate bot changed the title [deps] Platform: Update Rust crate zbus to v5 [deps] Platform: Update Rust crate zbus to v5 - autoclosed Dec 3, 2024
@renovate renovate bot closed this Dec 3, 2024
@renovate renovate bot deleted the renovate/zbus-5.x branch December 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant