Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10318] Add organization user deletion and leaving events to EventService #11554

Merged
merged 8 commits into from
Nov 8, 2024

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Oct 15, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10338

📔 Objective

Add organization user deletion and leaving events to EventService.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome marked this pull request as ready for review October 15, 2024 11:09
@r-tome r-tome requested a review from a team as a code owner October 15, 2024 11:09
@r-tome r-tome requested a review from addisonbeck October 15, 2024 11:09
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Logo
Checkmarx One – Scan Summary & Details54a899c3-83b4-4a4e-aee0-2b4645fe1a24

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/cipher-view.component.ts: 46 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/cipher-view.component.ts: 46 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/cipher-view.component.ts: 47 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-view/cipher-view.component.ts: 47 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/all-applications.component.html: 99 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/all-applications.component.html: 94 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/critical-applications.component.html: 85 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/critical-applications.component.html: 80 Attack Vector
MEDIUM Missing_HSTS_Header /libs/common/src/services/api.service.ts: 228 Attack Vector

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.62%. Comparing base (f5e6fc8) to head (973bb75).
Report is 21 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/core/event.service.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11554   +/-   ##
=======================================
  Coverage   33.62%   33.62%           
=======================================
  Files        2825     2825           
  Lines       88200    88208    +8     
  Branches    16800    16800           
=======================================
+ Hits        29655    29664    +9     
+ Misses      56223    56222    -1     
  Partials     2322     2322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

addisonbeck
addisonbeck previously approved these changes Oct 23, 2024
addisonbeck
addisonbeck previously approved these changes Oct 28, 2024
@r-tome r-tome requested a review from addisonbeck November 7, 2024 15:06
@r-tome r-tome merged commit 1f0c1f1 into main Nov 8, 2024
67 checks passed
@r-tome r-tome deleted the ac/pm-10318/add-org-leave-left-event-types branch November 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants