Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-471] Update lock icon and others #11508

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[CL-471] Update lock icon and others #11508

merged 3 commits into from
Oct 11, 2024

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Oct 11, 2024

🎟️ Tracking

CL-471

📔 Objective

This PR updates the lock icon so that the keyhole lines up properly with the lock-f icon. Updating the icon file also added some other minor icon updates and a few new ones, which have been added to the Storybook page for icons.

📸 Screenshots

Screen.Recording.2024-10-11.at.11.02.45.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Logo
Checkmarx One – Scan Summary & Details36ce093a-2912-40d4-adda-73a1ca4fec0b

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.17%. Comparing base (346329c) to head (1ffc421).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11508   +/-   ##
=======================================
  Coverage   33.16%   33.17%           
=======================================
  Files        2779     2779           
  Lines       86223    86223           
  Branches    16420    16420           
=======================================
+ Hits        28597    28604    +7     
+ Misses      55360    55353    -7     
  Partials     2266     2266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 marked this pull request as ready for review October 11, 2024 15:19
@vleague2 vleague2 requested a review from a team as a code owner October 11, 2024 15:19
Copy link
Member

@danielleflinn danielleflinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified lock icon keyhole is appearing as expected

@vleague2 vleague2 merged commit 988c2b6 into main Oct 11, 2024
66 checks passed
@vleague2 vleague2 deleted the ds/cl-471/icon-update branch October 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants