Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13410] Remove right angle icon from about bitwarden button #11503

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13410

📔 Objective

Design teak: Remove the right angle icon from about bitwarden button within settings

📸 Screenshots

Before

image

After

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner October 11, 2024 09:30
@djsmith85 djsmith85 enabled auto-merge (squash) October 11, 2024 09:30
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.16%. Comparing base (b9be15c) to head (97391df).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11503      +/-   ##
==========================================
- Coverage   33.18%   33.16%   -0.02%     
==========================================
  Files        2778     2779       +1     
  Lines       86216    86223       +7     
  Branches    16418    16420       +2     
==========================================
- Hits        28611    28597      -14     
- Misses      55338    55360      +22     
+ Partials     2267     2266       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa5a83012-e5ec-4e89-916c-4ca15324e8ba

No New Or Fixed Issues Found

@djsmith85 djsmith85 merged commit 784dd3c into main Oct 11, 2024
26 checks passed
@djsmith85 djsmith85 deleted the tools/PM-13410/remove-right-angle-icon-from-about-bitwarden-button branch October 11, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants