Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11405] Account Management: Prevent a verified user from changing their email address #11486

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Oct 10, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11405

📔 Objective

If the Account Deprovisioning feature flag is enabled and the user is managed by an organization then hide the Change Email component.

Server PR: bitwarden/server#4875

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome changed the base branch from main to ac/pm-11404/prevent-a-verified-user-from-purging-their-vault October 10, 2024 13:06
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Logo
Checkmarx One – Scan Summary & Detailse4e7ed97-5eb1-47f9-b667-f4076ad20a77

No New Or Fixed Issues Found

…vault' into ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address
…vault' into ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.58%. Comparing base (2a95674) to head (e3ec094).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/app/auth/settings/account/account.component.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11486      +/-   ##
==========================================
- Coverage   33.59%   33.58%   -0.01%     
==========================================
  Files        2810     2810              
  Lines       87262    87265       +3     
  Branches    16634    16635       +1     
==========================================
- Hits        29312    29305       -7     
- Misses      55647    55657      +10     
  Partials     2303     2303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-tome r-tome changed the title [PM-11405] Account Deprovisioning: Prevent a verified user from changing their email address [PM-11405] Account Management: Prevent a verified user from changing their email address Oct 11, 2024
Base automatically changed from ac/pm-11404/prevent-a-verified-user-from-purging-their-vault to main October 17, 2024 15:06
@r-tome r-tome force-pushed the ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address branch from 7b2c68b to e219cb7 Compare October 18, 2024 10:33
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-tome r-tome merged commit 203a7b0 into main Oct 28, 2024
34 of 35 checks passed
@r-tome r-tome deleted the ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address branch October 28, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants