Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Modal Experiment #11484

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
+237 −19

feat: reset setting on app start

8b30e71
Select commit
Loading
Failed to load commit list.
Open

Desktop Modal Experiment #11484

feat: reset setting on app start
8b30e71
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 1s

33.53% (-0.03%) compared to 997d40f

View this Pull Request on Codecov

33.53% (-0.03%) compared to 997d40f

Details

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (997d40f) to head (8b30e71).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/main/window.main.ts 0.00% 26 Missing ⚠️
apps/desktop/src/platform/popup-modal-styles.ts 0.00% 25 Missing ⚠️
apps/desktop/src/main/tray.main.ts 0.00% 12 Missing ⚠️
...p/src/app/components/fido2placeholder.component.ts 0.00% 8 Missing ⚠️
.../src/platform/services/desktop-settings.service.ts 0.00% 6 Missing ⚠️
apps/desktop/src/app/services/init.service.ts 0.00% 3 Missing ⚠️
apps/desktop/src/app/app-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11484      +/-   ##
==========================================
- Coverage   33.56%   33.53%   -0.03%     
==========================================
  Files        2926     2928       +2     
  Lines       91527    91605      +78     
  Branches    17395    17412      +17     
==========================================
- Hits        30721    30720       -1     
- Misses      58392    58471      +79     
  Partials     2414     2414

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov