[AC-3082] Split invoice history table into two tables for paid and open #11459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11459 +/- ##
==========================================
- Coverage 33.19% 33.18% -0.02%
==========================================
Files 2772 2772
Lines 86068 86089 +21
Branches 16396 16400 +4
==========================================
- Hits 28573 28566 -7
- Misses 55229 55257 +28
Partials 2266 2266 ☔ View full report in Codecov by Sentry. |
amorask-bitwarden
approved these changes
Oct 8, 2024
| @@ -51,15 +58,20 @@ export class BillingHistoryViewComponent implements OnInit { | |||
| : null, | |||
| ); | |||
|
|
|||
| const accountInvoices = await invoicesPromise; | |||
| const accountTransactions = await transactionsPromise; | |||
| const openInvoices = await openInvoicesPromise; | |||
There was a problem hiding this comment.
⛏️ Can Promise.all these if you want, but I'm not js-y enough to know it has any meaningful performance impact.
cturnbull-bitwarden
added a commit
that referenced
this pull request
Oct 9, 2024
(cherry picked from commit 49b26db)
Larry-Sussman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-3082
📔 Objective
Split the invoices table into two tables for two specific status: "open" and "unpaid."
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes