-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14270] Use rust to access windows registry #11413
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11413 +/- ##
=======================================
Coverage 33.51% 33.52%
=======================================
Files 2815 2815
Lines 87560 87540 -20
Branches 16689 16689
=======================================
Hits 29349 29349
+ Misses 55903 55883 -20
Partials 2308 2308 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
1b1e573
to
5d3ed83
Compare
5d3ed83
to
bf7c681
Compare
bf7c681
to
70c9424
Compare
🎟️ Tracking
📔 Objective
Using the
regedit
NPM library, we have to bundle some.vbs
scripts to ensure that we can create registry entries on Windows. vbscript is being deprecated, so we should replace that code by a native rust module using thewindows-registry
crate.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes