Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14270] Use rust to access windows registry #11413

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Oct 4, 2024

🎟️ Tracking

📔 Objective

Using the regedit NPM library, we have to bundle some .vbs scripts to ensure that we can create registry entries on Windows. vbscript is being deprecated, so we should replace that code by a native rust module using the windows-registry crate.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (f6755da) to head (242c42d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/main/native-messaging.main.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11413   +/-   ##
=======================================
  Coverage   33.51%   33.52%           
=======================================
  Files        2815     2815           
  Lines       87560    87540   -20     
  Branches    16689    16689           
=======================================
  Hits        29349    29349           
+ Misses      55903    55883   -20     
  Partials     2308     2308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One – Scan Summary & Details1e1935b7-48a9-486d-9f91-a5fb253b92aa

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 35
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 105
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 100
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 105
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 110

@dani-garcia dani-garcia force-pushed the ps/use-rust-for-regedit branch 3 times, most recently from 1b1e573 to 5d3ed83 Compare October 11, 2024 18:28
@dani-garcia dani-garcia force-pushed the ps/use-rust-for-regedit branch from 5d3ed83 to bf7c681 Compare October 30, 2024 16:16
@dani-garcia dani-garcia force-pushed the ps/use-rust-for-regedit branch from bf7c681 to 70c9424 Compare October 30, 2024 16:18
@dani-garcia dani-garcia changed the title Use rust to access windows registry [PM-14270] Use rust to access windows registry Oct 30, 2024
@dani-garcia dani-garcia marked this pull request as ready for review October 31, 2024 18:20
@dani-garcia dani-garcia requested a review from a team as a code owner October 31, 2024 18:20
@dani-garcia dani-garcia requested a review from coroiu October 31, 2024 18:20
@dani-garcia dani-garcia merged commit 2e6ed4a into main Nov 4, 2024
66 checks passed
@dani-garcia dani-garcia deleted the ps/use-rust-for-regedit branch November 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants