[PM-12281] [PM-12301] [PM-12306] [PM-12334] Move delete item permission to Can Manage

[gbubemismith]

🎟️ Tracking

PM-12281
PM-12301
PM-12306
PM-12334

📔 Objective

Currently, users with Can Edit permissions can delete items within the collection. This should be updated so that only users with the Can Manage permission can delete items within a collection.

📸 Screenshots

Web

Screen.Recording.2024-09-20.at.12.35.28.PM.mov

Desktop

Screen.Recording.2024-09-27.at.6.19.17.PM.mov

Extension

Screen.Recording.2024-09-27.at.6.16.49.PM.mov

Cli

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 30.52632% with 66 lines in your changes missing coverage. Please review.

Project coverage is 33.15%. Comparing base (fa41f29) to head (8936af9).
Report is 79 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...lt/components/vault-items/vault-items.component.ts	0.00%	30 Missing ⚠️
.../src/app/vault/individual-vault/vault.component.ts	0.00%	5 Missing ⚠️
...angular/src/vault/components/add-edit.component.ts	0.00%	5 Missing ⚠️
...src/vault/popup/components/vault/view.component.ts	0.00%	4 Missing ⚠️
apps/cli/src/vault/delete.command.ts	0.00%	4 Missing ⚠️
...ibs/angular/src/vault/components/view.component.ts	0.00%	4 Missing ⚠️
apps/browser/src/background/main.background.ts	0.00%	2 Missing ⚠️
...vault/popup/components/vault/add-edit.component.ts	0.00%	2 Missing ⚠️
...s/vault-item-dialog/vault-item-dialog.component.ts	50.00%	2 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts	0.00%	2 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11289      +/-   ##
==========================================
- Coverage   33.16%   33.15%   -0.02%     
==========================================
  Files        2779     2780       +1     
  Lines       86225    86391     +166     
  Branches    16420    16477      +57     
==========================================
+ Hits        28597    28640      +43     
- Misses      55362    55469     +107     
- Partials     2266     2282      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 181097fe-c9cd-4aad-b1b0-244243e4d69c

No New Or Fixed Issues Found

[shane-melton]

Looks good, nice work!