Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12747] Move CollectionService and models to AC Team #11278

Merged
merged 13 commits into from
Oct 8, 2024

Merge remote-tracking branch 'origin/main' into ac/pm-12747/clients-m…

d459031
Select commit
Loading
Failed to load commit list.
Merged

[PM-12747] Move CollectionService and models to AC Team #11278

Merge remote-tracking branch 'origin/main' into ac/pm-12747/clients-m…
d459031
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 0s

33.18% (-0.10%) compared to bf042ef

View this Pull Request on Codecov

33.18% (-0.10%) compared to bf042ef

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 33.18%. Comparing base (bf042ef) to head (d459031).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/background/main.background.ts 0.00% 2 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 1 Missing ⚠️
...assign-collections/assign-collections.component.ts 0.00% 1 Missing ⚠️
...vault/popup/components/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
...lt/popup/components/vault/collections.component.ts 0.00% 1 Missing ⚠️
...rc/vault/popup/components/vault/share.component.ts 0.00% 1 Missing ⚠️
...lt/popup/components/vault/vault-items.component.ts 0.00% 1 Missing ⚠️
apps/cli/src/commands/edit.command.ts 0.00% 1 Missing ⚠️
apps/cli/src/commands/get.command.ts 0.00% 1 Missing ⚠️
apps/cli/src/commands/list.command.ts 0.00% 1 Missing ⚠️
... and 28 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11278      +/-   ##
==========================================
- Coverage   33.28%   33.18%   -0.10%     
==========================================
  Files        2741     2772      +31     
  Lines       85810    86061     +251     
  Branches    16367    16394      +27     
==========================================
+ Hits        28559    28561       +2     
- Misses      54987    55235     +248     
- Partials     2264     2265       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov