Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11199] added permission labels to ciphers in AC #11210

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Sep 23, 2024

🎟️ Tracking

PM-11199

📔 Objective

  • Adding Permission Labels to Ciphers in AC.
  • If a cipher belongs to multiple collections make sure the label shows the highest lvl permission
  • If the Owners and Admins can manage setting is ON continue to show the permission for that item based on the collection.

📸 Screen Recording

PM-11199.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner September 23, 2024 22:36
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 33.16%. Comparing base (a884fcf) to head (22f2a2f).
Report is 73 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mponents/vault-items/vault-cipher-row.component.ts 0.00% 22 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11210      +/-   ##
==========================================
- Coverage   33.16%   33.16%   -0.01%     
==========================================
  Files        2779     2779              
  Lines       86235    86257      +22     
  Branches    16425    16431       +6     
==========================================
  Hits        28604    28604              
- Misses      55365    55387      +22     
  Partials     2266     2266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Logo
Checkmarx One – Scan Summary & Details6c113eb9-6731-4540-89b8-22ff5e0bcaf5

No New Or Fixed Issues Found

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may be potential to simplify this a bit, let me know what you think!

@Jingo88 Jingo88 added the needs-qa Marks a PR as requiring QA approval label Sep 30, 2024
shane-melton
shane-melton previously approved these changes Sep 30, 2024
gbubemismith
gbubemismith previously approved these changes Oct 2, 2024
@Jingo88 Jingo88 removed the needs-qa Marks a PR as requiring QA approval label Oct 22, 2024
@Jingo88 Jingo88 merged commit 023abe2 into main Oct 22, 2024
34 of 36 checks passed
@Jingo88 Jingo88 deleted the PM-11199-perm-column branch October 22, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants