-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11199] added permission labels to ciphers in AC #11210
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11210 +/- ##
==========================================
- Coverage 33.16% 33.16% -0.01%
==========================================
Files 2779 2779
Lines 86235 86257 +22
Branches 16425 16431 +6
==========================================
Hits 28604 28604
- Misses 55365 55387 +22
Partials 2266 2266 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there may be potential to simplify this a bit, let me know what you think!
apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts
Show resolved
Hide resolved
c21e5a5
🎟️ Tracking
PM-11199
📔 Objective
Owners and Admins can manage
setting is ON continue to show the permission for that item based on the collection.📸 Screen Recording
PM-11199.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes